Skip to content

Use icu crates instead of caseless/unicode-normalization in places #7115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhammond merged 1 commit into from
Dec 4, 2025
Merged

Use icu crates instead of caseless/unicode-normalization in places #7115

mhammond merged 1 commit into from
Dec 4, 2025
+9 −160

Conversation

@mhammond
Copy link
Member

@mhammond mhammond commented Dec 4, 2025

I don't fully understand why we can't just starts_with, but I didn't dig too deep and left the core logic alone.

m-c really doesn't want unicode-normalization

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@mhammond
Use icu crates instead of caseless/unicode_normalization in places
37e7e4a 
I don't fully understand why we can't just `starts_with`, but I didn't
dig too deep and left the core logic alone.
@mhammond mhammond requested a review from bendk December 4, 2025 04:29
bendk
bendk approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't understand the need for the case folding either, but this seems like a fine way to fix the dependency issue without too many code changes.

@mhammond mhammond added this pull request to the merge queue Dec 4, 2025
Merged via the queue into mozilla:main with commit 0376c54 Dec 4, 2025
14 checks passed
@mhammond mhammond deleted the push-skrlpkwsumyu branch December 4, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bendk bendk bendk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhammond @bendk